mirror of
https://github.com/itme-brain/agent-team.git
synced 2026-05-08 11:40:12 -04:00
fix: resolve review round 3 findings
- reviewer, auditor: add qa-checklist to skills (both produce envelopes) - worker-protocol: annotate ac_coverage as optional in envelope template - message-schema: document that security_findings.high is non-blocking - qa-checklist: reframe plan_result has_blockers as intent confirmation
This commit is contained in:
parent
76f7f16eff
commit
7fdbb40656
5 changed files with 5 additions and 3 deletions
|
|
@ -9,6 +9,7 @@ maxTurns: 25
|
||||||
skills:
|
skills:
|
||||||
- conventions
|
- conventions
|
||||||
- message-schema
|
- message-schema
|
||||||
|
- qa-checklist
|
||||||
- project
|
- project
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -9,6 +9,7 @@ maxTurns: 20
|
||||||
skills:
|
skills:
|
||||||
- conventions
|
- conventions
|
||||||
- message-schema
|
- message-schema
|
||||||
|
- qa-checklist
|
||||||
- project
|
- project
|
||||||
---
|
---
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -118,7 +118,7 @@ typecheck_status: pass | fail | skipped
|
||||||
Required: `type`, `signal`, `security_findings`, `build_status`, `test_status`
|
Required: `type`, `signal`, `security_findings`, `build_status`, `test_status`
|
||||||
Optional: `typecheck_status`
|
Optional: `typecheck_status`
|
||||||
|
|
||||||
**Hard rule:** `security_findings.critical > 0` or `build_status: fail` or `test_status: fail` requires `signal: fail`.
|
**Hard rule:** `security_findings.critical > 0` or `build_status: fail` or `test_status: fail` requires `signal: fail`. High-severity findings (`security_findings.high > 0`) do not require `fail` — use `pass_with_notes`.
|
||||||
|
|
||||||
Body: Security findings by severity (or CLEAN), then Runtime section with tested/passed/failed.
|
Body: Security findings by severity (or CLEAN), then Runtime section with tested/passed/failed.
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -48,7 +48,7 @@ Before returning your output, validate against every item below. If you find a v
|
||||||
- Are hard rules satisfied?
|
- Are hard rules satisfied?
|
||||||
- `review_verdict`: `critical_count > 0` requires `signal: fail`
|
- `review_verdict`: `critical_count > 0` requires `signal: fail`
|
||||||
- `audit_verdict`: `security_findings.critical > 0` or `build_status: fail` or `test_status: fail` requires `signal: fail`
|
- `audit_verdict`: `security_findings.critical > 0` or `build_status: fail` or `test_status: fail` requires `signal: fail`
|
||||||
- `plan_result`: `has_blockers: true` requires orchestrator escalation to user before worker dispatch
|
- `plan_result`: if you set `has_blockers: true`, confirm this is intentional — it triggers user escalation before worker dispatch
|
||||||
|
|
||||||
## After validation
|
## After validation
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -15,7 +15,7 @@ signal: rfr | blocked | escalate
|
||||||
files_changed:
|
files_changed:
|
||||||
- path/to/file1
|
- path/to/file1
|
||||||
- path/to/file2
|
- path/to/file2
|
||||||
ac_coverage:
|
ac_coverage: # optional — omit when no AC provided
|
||||||
AC1: pass | fail | partial | na
|
AC1: pass | fail | partial | na
|
||||||
AC2: pass | fail | partial | na
|
AC2: pass | fail | partial | na
|
||||||
qa_check: pass | fail
|
qa_check: pass | fail
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue