mirror of
https://github.com/itme-brain/agent-team.git
synced 2026-05-08 16:00:11 -04:00
fix(protocol): tighten workflow contract
This commit is contained in:
parent
3a2d565aaa
commit
54acfec834
4 changed files with 16 additions and 11 deletions
|
|
@ -80,7 +80,7 @@ typecheck_status: pass | fail | skipped
|
|||
---
|
||||
```
|
||||
|
||||
**Hard rule:** `security_findings.critical > 0` or `build_status: fail` or `test_status: fail` requires `signal: fail`.
|
||||
**Hard rule:** `security_findings.critical > 0` or `security_findings.high > 0` or `build_status: fail` or `test_status: fail` requires `signal: fail`.
|
||||
|
||||
Then the markdown body:
|
||||
|
||||
|
|
|
|||
|
|
@ -28,7 +28,7 @@ Shell access is intentionally unavailable in this role to enforce read-only beha
|
|||
|
||||
## Claim verification
|
||||
|
||||
- **Acceptance criteria** — walk each criterion explicitly by number. Clean code that doesn't do what was asked is a FAIL.
|
||||
- **Acceptance criteria** — when acceptance criteria are provided, walk each criterion explicitly by number. Clean code that doesn't do what was asked is a FAIL.
|
||||
- **API and library usage** — verify against official docs ${WEB_SEARCH} when the implementation uses external APIs, libraries, or non-obvious patterns
|
||||
- **File and path claims** — do they exist?
|
||||
- **Logic correctness** — does the implementation actually solve the problem?
|
||||
|
|
@ -57,6 +57,8 @@ ac_coverage:
|
|||
|
||||
**Hard rule:** `critical_count > 0` requires `signal: fail`.
|
||||
|
||||
Omit `ac_coverage` when no acceptance criteria were provided in the assignment.
|
||||
|
||||
Then the markdown body:
|
||||
|
||||
### Review: [scope]
|
||||
|
|
@ -75,6 +77,8 @@ Then the markdown body:
|
|||
- AC2: PASS / FAIL — [one line]
|
||||
- ...
|
||||
|
||||
Omit the **AC Coverage** section when no acceptance criteria were provided.
|
||||
|
||||
One line summary.
|
||||
|
||||
---
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue